Add public primitive font-size token layer
#10439
Assignees
Comments
lgriffee
added a commit
that referenced
this issue
Sep 14, 2023
### WHY are these changes introduced? Fixes #10475 Part of #10439 ### WHAT is this pull request doing? Adds the following values to new public primitive `font-size` token scale: | New Token | Value | Value (in px) | ------------------------- | ------------------------ | ------------------------ | | `--p-font-size-275` | `size[275]` | `11px` | | ~`--p-font-size-300`~ | ~`size[300]`~ | ~`12px`~ | | `--p-font-size-325` | `size[325]` | `13px` | | `--p-font-size-350` | `size[350]` | `14px` | | ~`--p-font-size-400`~ | ~`size[400]`~ | ~`16px`~ | | ~`--p-font-size-500`~ | ~`size[500]`~ | ~`20px`~ | | ~`--p-font-size-600`~ | ~`size[600]`~ | ~`24px`~ | | `--p-font-size-750` | `size[750]` | `30px` | | `--p-font-size-900` | `size[900]` | `36px` | | `--p-font-size-1000` | `size[1000]` | `40px` | > [!NOTE] > The following values were not added since they conflict with existing tokens with the same name. These tokens will have their values updated in the next major version v12: | New Token | Value | Value (in px) | ------------------------- | ------------------------ | ------------------------ | | `--p-font-size-300` | `size[300]` | `12px` | | `--p-font-size-400` | `size[400]` | `16px` | | `--p-font-size-500` | `size[500]` | `20px` | | `--p-font-size-600` | `size[600]` | `24px` |
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this issue
Apr 22, 2024
### WHY are these changes introduced? Fixes Shopify#10475 Part of Shopify#10439 ### WHAT is this pull request doing? Adds the following values to new public primitive `font-size` token scale: | New Token | Value | Value (in px) | ------------------------- | ------------------------ | ------------------------ | | `--p-font-size-275` | `size[275]` | `11px` | | ~`--p-font-size-300`~ | ~`size[300]`~ | ~`12px`~ | | `--p-font-size-325` | `size[325]` | `13px` | | `--p-font-size-350` | `size[350]` | `14px` | | ~`--p-font-size-400`~ | ~`size[400]`~ | ~`16px`~ | | ~`--p-font-size-500`~ | ~`size[500]`~ | ~`20px`~ | | ~`--p-font-size-600`~ | ~`size[600]`~ | ~`24px`~ | | `--p-font-size-750` | `size[750]` | `30px` | | `--p-font-size-900` | `size[900]` | `36px` | | `--p-font-size-1000` | `size[1000]` | `40px` | > [!NOTE] > The following values were not added since they conflict with existing tokens with the same name. These tokens will have their values updated in the next major version v12: | New Token | Value | Value (in px) | ------------------------- | ------------------------ | ------------------------ | | `--p-font-size-300` | `size[300]` | `12px` | | `--p-font-size-400` | `size[400]` | `16px` | | `--p-font-size-500` | `size[500]` | `20px` | | `--p-font-size-600` | `size[600]` | `24px` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tasks
font-sizetokens that don't conflict with the names of existing tokens #10475font-sizetoken values #10476The text was updated successfully, but these errors were encountered: