Add public primitive font-size token scale
#10474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronccasanova
approved these changes
Sep 14, 2023
Merged
mattkubej
pushed a commit
that referenced
this pull request
Sep 15, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@11.19.0 ### Minor Changes - [#10310](#10310) [`5f94cae98`](5f94cae) Thanks [@mattkubej](https://github.com/mattkubej)! - Added a `type` prop to `Pagination` to support a table row layout ### Patch Changes - Updated dependencies \[[`5e073c209`](5e073c2), [`2bccc2291`](2bccc22), [`033424546`](0334245), [`66b2599da`](66b2599), [`c07de6ca4`](c07de6c)]: - @shopify/polaris-tokens@7.9.0 ## @shopify/polaris-tokens@7.9.0 ### Minor Changes - [#10458](#10458) [`5e073c209`](5e073c2) Thanks [@lgriffee](https://github.com/lgriffee)! - Added public primitive `height` token scale - [#10462](#10462) [`2bccc2291`](2bccc22) Thanks [@lgriffee](https://github.com/lgriffee)! - Added public primitive `line-height` token scale - [#10474](#10474) [`033424546`](0334245) Thanks [@lgriffee](https://github.com/lgriffee)! - Added public primitive `font-size` token scale - [#10434](#10434) [`66b2599da`](66b2599) Thanks [@lgriffee](https://github.com/lgriffee)! - Added public primitive `border-width` token scale - [#10460](#10460) [`c07de6ca4`](c07de6c) Thanks [@lgriffee](https://github.com/lgriffee)! - Added public primitive `width` token scale ## @shopify/polaris-migrator@0.22.4 ### Patch Changes - Updated dependencies \[[`5e073c209`](5e073c2), [`2bccc2291`](2bccc22), [`033424546`](0334245), [`66b2599da`](66b2599), [`c07de6ca4`](c07de6c)]: - @shopify/polaris-tokens@7.9.0 - @shopify/stylelint-polaris@14.0.4 ## @shopify/stylelint-polaris@14.0.4 ### Patch Changes - Updated dependencies \[[`5e073c209`](5e073c2), [`2bccc2291`](2bccc22), [`033424546`](0334245), [`66b2599da`](66b2599), [`c07de6ca4`](c07de6c)]: - @shopify/polaris-tokens@7.9.0 ## polaris.shopify.com@0.57.7 ### Patch Changes - Updated dependencies \[[`5f94cae98`](5f94cae), [`5e073c209`](5e073c2), [`2bccc2291`](2bccc22), [`033424546`](0334245), [`66b2599da`](66b2599), [`c07de6ca4`](c07de6c)]: - @shopify/polaris@11.19.0 - @shopify/polaris-tokens@7.9.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Fixes Shopify#10475 Part of Shopify#10439 ### WHAT is this pull request doing? Adds the following values to new public primitive `font-size` token scale: | New Token | Value | Value (in px) | ------------------------- | ------------------------ | ------------------------ | | `--p-font-size-275` | `size[275]` | `11px` | | ~`--p-font-size-300`~ | ~`size[300]`~ | ~`12px`~ | | `--p-font-size-325` | `size[325]` | `13px` | | `--p-font-size-350` | `size[350]` | `14px` | | ~`--p-font-size-400`~ | ~`size[400]`~ | ~`16px`~ | | ~`--p-font-size-500`~ | ~`size[500]`~ | ~`20px`~ | | ~`--p-font-size-600`~ | ~`size[600]`~ | ~`24px`~ | | `--p-font-size-750` | `size[750]` | `30px` | | `--p-font-size-900` | `size[900]` | `36px` | | `--p-font-size-1000` | `size[1000]` | `40px` | > [!NOTE] > The following values were not added since they conflict with existing tokens with the same name. These tokens will have their values updated in the next major version v12: | New Token | Value | Value (in px) | ------------------------- | ------------------------ | ------------------------ | | `--p-font-size-300` | `size[300]` | `12px` | | `--p-font-size-400` | `size[400]` | `16px` | | `--p-font-size-500` | `size[500]` | `20px` | | `--p-font-size-600` | `size[600]` | `24px` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #10475
Part of #10439
WHAT is this pull request doing?
Adds the following values to new public primitive
font-sizetoken scale:--p-font-size-275size[275]11px--p-font-size-300size[300]12px--p-font-size-325size[325]13px--p-font-size-350size[350]14px--p-font-size-400size[400]16px--p-font-size-500size[500]20px--p-font-size-600size[600]24px--p-font-size-750size[750]30px--p-font-size-900size[900]36px--p-font-size-1000size[1000]40pxNote
The following values were not added since they conflict with existing tokens with the same name. These tokens will have their values updated in the next major version v12:
--p-font-size-300size[300]12px--p-font-size-400size[400]16px--p-font-size-500size[500]20px--p-font-size-600size[600]24px