Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual color token updates (epic) #10351

Closed
20 tasks done
sarahill opened this issue Sep 6, 2023 · 0 comments
Closed
20 tasks done

Manual color token updates (epic) #10351

sarahill opened this issue Sep 6, 2023 · 0 comments

Comments

@sarahill
Copy link
Contributor

sarahill commented Sep 6, 2023

Update color token application for components as part of the token reconciliation work for v12. There are a couple cases where we will need to manually update polaris components to get the appropriate tokens.

Updating components to use on-bg-fill colors

With the introduction of bg-fill and on-bg-fill colors the previous on-color tokens don't have a direct 1:1 mapping and need a manual update to get the expected visual style. We'll need to make this update in web too.

Clean up color token application

The other case is cleaning up hacky token application from the uplift. In some cases, we had to use a mix of roles to get the colors we needed because the current system wasn't scaling to our needs. Now, we can update polaris components for consumers to use an example of token application in the udpated system.

Manual color token migrations

  1. #gsd:36565
    aveline
  2. #gsd:36565
    gwyneplaine
  3. #gsd:36565
    gwyneplaine
  4. #gsd:36565
    chloerice
  5. #gsd:36565
    aveline
  6. #gsd:36565
    aveline
  7. #gsd:36565
    laurkim
  8. #gsd:36565
    laurkim
  9. #gsd:36565
    aveline
  10. #gsd:36565
    laurkim
  11. #gsd:36565
    laurkim
  12. #gsd:36565
    sophschneider
  13. sophschneider
  14. #gsd:36565
    aveline
  15. #gsd:36565
    sophschneider
  16. #gsd:36565
    aveline
  17. #gsd:36565
    laurkim
  18. #gsd:36565
    sophschneider
  19. aaronccasanova sophschneider
  20. #gsd:36565
    sophschneider
@sarahill sarahill changed the title Manual color token updates Manual color token updates (epic) Sep 14, 2023
@laurkim laurkim removed the untriaged label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants