Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AerCircuit from result of backend.run() #1845

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

hhorii
Copy link
Collaborator

@hhorii hhorii commented Jun 13, 2023

Summary

Since #1772, results of C++ library include AerCircuit as metadata to identify a template circuit. This metadata is internally delivered to users by calling backend.run().result(). If a user copies the metadata, errors are happened because AerCircuit is not serializable.

Details and comments

Remove AerCircuit objects from any results of backend.run()

@hhorii hhorii added stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable Changelog: Bugfix Include in the Fixed section of the changelog labels Jun 13, 2023
jakelishman
jakelishman previously approved these changes Jun 13, 2023
@jakelishman jakelishman added the automerge This PR will automatically merge once its CI has passed label Jun 13, 2023
@mergify mergify bot merged commit a598075 into Qiskit:main Jun 13, 2023
@hhorii hhorii deleted the remove_metadata_circuit_from_result branch June 13, 2023 12:43
@hhorii hhorii added this to the Aer 0.12.2 milestone Jun 26, 2023
hhorii added a commit to hhorii/qiskit-aer that referenced this pull request Jul 7, 2023
* take AerCircuit from _metadata in experiment result

* add reno

* Fix rST formatting

---------

Co-authored-by: Jake Lishman <jake@binhbar.com>
hhorii added a commit that referenced this pull request Jul 12, 2023
* bump version strings and prepare for release

* Remove `AerCircuit` from result of `backend.run()` (#1845)

* take AerCircuit from _metadata in experiment result

* add reno

* Fix rST formatting

---------

Co-authored-by: Jake Lishman <jake@binhbar.com>

* pin numpy version lower than 1.25 (#1859)

* Fix param positions for circuits with conditionals (#1851)

* fix parameter indexing issues.

* fix issues in parameterization of global phase

* add reno

* fix lint

* fix release note

* fix a bug to call _convert_circuit_binds

* add test

* Support save_statevector for QuantumCircuit from QASM3 string (#1846)

* Support save_statevector for QuantumCircuit from QASM3 string

* add qiskit_qasm3_import to requirements-dev.txt

* simplify default_qubits()

* fix lint error

* skip qasm3 circuit test in 3.7

* New GPU binaries with cuQuantum support (#1854)

* New GPU binaries with cuQuantum support

* format setup.py

* remove testpipy settings

* Update setup.py to use numpy with version lower than 1.25

* changed package names, qiskit-aer-gpu for CUDA12, and qiskit-aer-gpu-cu11 for 11

* format setup.py

* Update README.md

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Update releasenotes/notes/renew_gpu_binaries-2cf3eba0853b8407.yaml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* update release note

---------

Co-authored-by: Hiroshi Horii <hhorii@users.noreply.github.com>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* bump up python version from 3.7 to 3.8 to run cibuildwheel (#1867)

* bump up python version from 3.7 to 3.8 to run cibuildwheel

* bump up all python version in deploy workflow

* add reno

* set numpy version constraint only in dev (#1871)

* add numpy version constraint only in dev

* set numpy version constraint in contraints.txt

* bump up version in docs

---------

Co-authored-by: Jake Lishman <jake@binhbar.com>
Co-authored-by: Jun Doi <doichan@jp.ibm.com>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge This PR will automatically merge once its CI has passed Changelog: Bugfix Include in the Fixed section of the changelog stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants