Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Aer to known good version #10270

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Conversation

jakelishman
Copy link
Member

Summary

The release of Aer 0.12.1 included a bug in the results output that made the general Result object unpickleable. Several places in our tests assume that these objects should be able to be pickled to be sent across a process boundary, or such like.

Details and comments

See Qiskit/qiskit-aer#1845

The release of Aer 0.12.1 included a bug in the results output that made
the general `Result` object unpickleable.  Several places in our tests
assume that these objects should be able to be pickled to be sent across
a process boundary, or such like.
@jakelishman jakelishman added type: qa Issues and PRs that relate to testing and code quality stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Jun 13, 2023
@jakelishman jakelishman requested a review from a team as a code owner June 13, 2023 11:06
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5254946605

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 18 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 85.941%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 2 91.14%
crates/accelerate/src/sabre_swap/layer.rs 4 97.32%
crates/qasm2/src/parse.rs 12 96.65%
Totals Coverage Status
Change from base Build 5247473935: 0.02%
Covered Lines: 71451
Relevant Lines: 83140

💛 - Coveralls

@mtreinish mtreinish enabled auto-merge June 13, 2023 12:18
@mtreinish mtreinish added this pull request to the merge queue Jun 13, 2023
Merged via the queue into Qiskit:main with commit 676d90c Jun 13, 2023
mergify bot pushed a commit that referenced this pull request Jun 13, 2023
* Pin Aer to known good version

The release of Aer 0.12.1 included a bug in the results output that made
the general `Result` object unpickleable.  Several places in our tests
assume that these objects should be able to be pickled to be sent across
a process boundary, or such like.

* Make GitHub Actions respect constraints

(cherry picked from commit 676d90c)
mtreinish pushed a commit that referenced this pull request Jun 13, 2023
* Pin Aer to known good version

The release of Aer 0.12.1 included a bug in the results output that made
the general `Result` object unpickleable.  Several places in our tests
assume that these objects should be able to be pickled to be sent across
a process boundary, or such like.

* Make GitHub Actions respect constraints

(cherry picked from commit 676d90c)

Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
@jakelishman jakelishman deleted the pin-aer-0.12.0 branch July 12, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants