Revert redeem integration test #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 19, 2019 18:17
jasonklein
previously requested changes
May 20, 2019
There was a problem hiding this comment.
A few comments, mostly refactoring and typographical. On refactoring, there is a fair amount of repetition (e.g., type definitions like RedeemRequest, functions like proveGateway, etc.)—can this be refactored?
Additionally, I suggest changing "unStake" and "UnStake" to "unstake" and "Unstake", respectively, globally.
Finally, when I lint, errors are raised, even in the files that are entirely new—please review and address.
test_integration/03_redeem_and_unstake/utils/revert_redeem_assertion.js
Outdated
Show resolved
Hide resolved
test_integration/03_redeem_and_unstake/utils/revert_redeem_assertion.js
Outdated
Show resolved
Hide resolved
test_integration/03_redeem_and_unstake/utils/progress_revert_redeem_assertion.js
Outdated
Show resolved
Hide resolved
0xsarvesh
suggested changes
May 27, 2019
test_integration/03_redeem_and_unstake/utils/revert_redeem_assertion.js
Outdated
Show resolved
Hide resolved
test_integration/03_redeem_and_unstake/utils/revert_redeem_assertion.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #610
Revert redeem integration test.