Redeem and Unstake after RevertStake #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonklein
previously requested changes
May 23, 2019
There was a problem hiding this comment.
Mostly looks good to me. My comments are small and largely track the ones I made in #747.
I see there are two different approaches taken in these test files: (a) its for each major step in the process and (b) one it for the whole integrated flow. I prefer the integrated flow approach here, but I nevertheless note the inconsistency and think that a ticket to bring the test files in alignment would be 🌟(cc: @deepesh-kn).
Also: as discussed offline, this PR and #747 both introduce a file (and class), revert_redeem_assertion.js that are not identical—these changes should be aligned.
test_integration/03_redeem_and_unstake/03_redeem_and_unstake_after_revert.js
Outdated
Show resolved
Hide resolved
test_integration/03_redeem_and_unstake/03_redeem_and_unstake_after_revert.js
Outdated
Show resolved
Hide resolved
test_integration/03_redeem_and_unstake/03_redeem_and_unstake_after_revert.js
Outdated
Show resolved
Hide resolved
test_integration/03_redeem_and_unstake/03_redeem_and_unstake_after_revert.js
Outdated
Show resolved
Hide resolved
test_integration/03_redeem_and_unstake/03_redeem_and_unstake_after_revert.js
Outdated
Show resolved
Hide resolved
test_integration/03_redeem_and_unstake/03_redeem_and_unstake_after_revert.js
Outdated
Show resolved
Hide resolved
|
Working on the review feedback ⏩ |
- Renamed the test file - Use cogateway.penalty function
|
Ready for review again 🚀 |
|
Resolving conflicts ⏰ 😿 |
…edeem_declared # Conflicts: # test_integration/03_redeem_and_unstake/utils/revert_redeem_assertion.js
|
Conflicts resolved ⛑ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #738