New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate integration test code. #756

Open

deepesh-kn opened this issue May 27, 2019 · 0 comments

Contributor

deepesh-kn commented May 27, 2019

This is a followup ticket for #747 (comment)

Integration tests have code duplication in separate files.

Common code can be extracted into a single place.
Test files can include the common file and perform the tests.

The example of the repeated code that can be extracted to a single place:

Stake
confirmStake
proveGateway
proveCoGateway
progressMint
progressStake

Similarly, the functions in the redeem tests.

deepesh-kn mentioned this issue

Revert redeem integration test #747

Merged

jasonklein assigned jasonklein and unassigned jasonklein

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment