Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix all_host_ids reference #20206

Merged
merged 1 commit into from
May 26, 2020
Merged

fix all_host_ids reference #20206

merged 1 commit into from
May 26, 2020

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented May 26, 2020

introduced in:
#20149

  1) EmsClusterController#show render listnav partial correctly for timeline page
     Failure/Error: sdate, edate = @tl_record.first_and_last_event(@tl_options.evt_type)

     NameError:
       undefined local variable or method `all_host_ids' for #<EmsCluster:0x000055e3fd7fb930>
       Did you mean?  all_relationship_ids

ManageIQ/manageiq-cross_repo-tests#131

@Fryguy
Copy link
Member

Fryguy commented May 26, 2020

Can you add cross_repo with the ui ?

introduced in:
ManageIQ#20149

```
  1) EmsClusterController#show render listnav partial correctly for timeline page
     Failure/Error: sdate, edate = @tl_record.first_and_last_event(@tl_options.evt_type)

     NameError:
       undefined local variable or method `all_host_ids' for #<EmsCluster:0x000055e3fd7fb930>
       Did you mean?  all_relationship_ids
```
kbrock added a commit to kbrock/manageiq-cross_repo-tests that referenced this pull request May 26, 2020
@kbrock
Copy link
Member Author

kbrock commented May 26, 2020

fixed byebug and added cross repo tests

@miq-bot
Copy link
Member

miq-bot commented May 26, 2020

Checked commit kbrock@2e27701 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 2 offenses detected

spec/models/ems_cluster_spec.rb

@agrare agrare merged commit b7f4dab into ManageIQ:master May 26, 2020
@kbrock kbrock deleted the ems_cluster_all branch May 26, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants