keep host and vm_or_template all_* rels in cluster #20205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-u
changed the title
d-m-u
force-pushed
the
fixing_specs_from_20149
branch
from
94c3b63
to
e6ff81c
Compare
caught by himdel
d-m-u
force-pushed
the
fixing_specs_from_20149
branch
from
e6ff81c
to
1641b8e
Compare
|
Checked commit d-m-u@1641b8e with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yeah, my fault.
I gutted the all_* relations in https://github.com/ManageIQ/manageiq/pull/20149/files on Friday and we were still using
vm_or_templateandhostcaught by @himdel, sorry Martin :(
cross repo test is here: ManageIQ/manageiq-cross_repo-tests#130
or um, go with Keenan's solution cause his is both smarter and tested.
closing in favor of #20206