change aggregation mixin methods into virtual attributes #20149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-u
changed the title
d-m-u
force-pushed
the
virtual_aggregate_things
branch
9 times, most recently
from
bba3159
to
3aeef98
Compare
d-m-u
force-pushed
the
virtual_aggregate_things
branch
12 times, most recently
from
e849e74
to
b27fb43
Compare
d-m-u
force-pushed
the
virtual_aggregate_things
branch
from
4af871f
to
3eb91c5
Compare
NickLaMuro
reviewed
May 22, 2020
spec/support/examples_group/shared_examples_for_aggregation_mixin.rb
Outdated
Show resolved
Hide resolved
d-m-u
force-pushed
the
virtual_aggregate_things
branch
from
3eb91c5
to
2f28af3
Compare
d-m-u
force-pushed
the
virtual_aggregate_things
branch
from
2f28af3
to
354b7ee
Compare
|
Checked commit d-m-u@354b7ee with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
NickLaMuro
approved these changes
May 22, 2020
There was a problem hiding this comment.
I think @kbrock has covered anything remaining with the models.
I am much more happy with the specs now, thanks! And this PR is already drastically different from when I looked at it, so thanks for taking all the suggestions/changes. Looks good to me.
kbrock
added a commit
to kbrock/manageiq
that referenced
this pull request
May 26, 2020
introduced in: ManageIQ#20149
kbrock
added a commit
to kbrock/manageiq
that referenced
this pull request
May 26, 2020
introduced in: ManageIQ#20149 ``` 1) EmsClusterController#show render listnav partial correctly for timeline page Failure/Error: sdate, edate = @tl_record.first_and_last_event(@tl_options.evt_type) NameError: undefined local variable or method `all_host_ids' for #<EmsCluster:0x000055e3fd7fb930> Did you mean? all_relationship_ids ```
kbrock
added a commit
to kbrock/manageiq
that referenced
this pull request
May 26, 2020
introduced in: ManageIQ#20149 ``` 1) EmsClusterController#show render listnav partial correctly for timeline page Failure/Error: sdate, edate = @tl_record.first_and_last_event(@tl_options.evt_type) NameError: undefined local variable or method `all_host_ids' for #<EmsCluster:0x000055e3fd7fb930> Did you mean? all_relationship_ids ```
d-m-u
added a commit
to d-m-u/manageiq-ui-classic
that referenced
this pull request
Jun 17, 2020
fixes `ManageIQ::Providers::Google::CloudManager Inst Including Associations (0.1ms - 1rows) [----] F, [2020-06-17T13:58:28.726000 #394303:ae790] FATAL -- : Error caught: [NoMethodError] undefined method 'all_vms_and_templates'` from ManageIQ/manageiq#20284 @miq-bot add_label bug broken in ManageIQ/manageiq#20149
d-m-u
added a commit
to d-m-u/manageiq-ui-classic
that referenced
this pull request
Jun 17, 2020
fixes `ManageIQ::Providers::Google::CloudManager Inst Including Associations (0.1ms - 1rows) [----] F, [2020-06-17T13:58:28.726000 #394303:ae790] FATAL -- : Error caught: [NoMethodError] undefined method 'all_vms_and_templates'` from ManageIQ/manageiq#20284 broken in ManageIQ/manageiq#20149
|
@h-kataria why do we want this backported to Jansa? Seems like it can live on master and get burned in for the Kasparov release. |
This was referenced Aug 7, 2020
This was referenced Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keenan got this virtual aggregate stuff working and we should use it.
@miq-bot assign @kbrock