[requests/providers_spec.rb] Jansa approved spec

[NickLaMuro]

There has been a bit of a saga with these specs:

• [Renderer] Fix duplicate includes with extra_cols #933 (comment)
• [Renderer] Fix duplicate includes with extra_cols #933 (comment)

And it mostly ties in with some code that was updated for kasparov and up for aggregate_vm_cpus, but wasn't backported to jansa (which was probably the right choice).

• change aggregation mixin methods into virtual attributes manageiq#20149

However, it caused the specs to behave differently on the two branches, and thus fail on jansa. The nice part about these originally is that these specs very much replicated what we were seeing here:

#923 (comment)

But since that isn't valid for both branches, it is better to use specs that are suited for both branches.

Links

• jansa branch failure report: [Renderer] Fix duplicate includes with extra_cols #933 (comment)
• Offending PRs:
  • [Renderer] Fix duplicate includes with extra_cols #933
  • [Renderer] Use next, not return #940
• Related code not in jansa: change aggregation mixin methods into virtual attributes manageiq#20149

QA steps

1. Pull down a local copy of this repo

2. Checkout the merge commit prior to my fix from [Renderer] Fix duplicate includes with extra_cols #933 being added to master

   $ git checkout c2dc6c96
   

3. Override the manageiq-api gem in bundler.d/

   override_gem 'manageiq-api', :path => '/Users/nicklamuro/code/redhat/manageiq-api'

From there, you should be able to repeat the testing you did for #923 but just change the attributes in the request to what is in the specs here:

/api/providers?expand=resources&attributes=name,total_vms,total_vms_and_templates

[NickLaMuro]

@miq-bot add_label test
@miq-bot assign @jrafanie

Hey LJ, I think you are best suited for double checking that these new specs are representative of what we ran into with #923 previously.

I need to re-run this spec on jansa just to make sure, but if you could test this prior to my fix in #933 and confirm that it is slow as well, that would be great!

[miq-bot]

Checked commit NickLaMuro@6d858a3 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍰

[NickLaMuro]

@jrafanie also, here are some hopefully easier instructions for setting up an environment to test what I was talking about in #946 (comment)

1. Pull down a local copy of this repo

2. Checkout the merge commit prior to my fix from [Renderer] Fix duplicate includes with extra_cols #933 being added to master

   $ git checkout c2dc6c96
   

3. Override the manageiq-api gem in bundler.d/

   override_gem 'manageiq-api', :path => '/Users/nicklamuro/code/redhat/manageiq-api'

From there, you should be able to repeat the testing you did for #923 but just change the attributes in the request to what is in the specs here:

/api/providers?expand=resources&attributes=name,total_vms,total_vms_and_templates

[chessbyte]

/cc @simaishi

[jrafanie]

I have confirmed that this PR recreates nearly the same exact problem from #923. I'm good with making the test master / jansa compatible to avoid pulling back other changes to jansa elsewhere for the purposes of a single set of tests.

[NickLaMuro]

Oh right, I forgot kasparov/yes would also be something we have to do now. Yes, this is needed to fix the jansa build, and should most definitely be brought to kasparov to be consistent with master/jansa.

[simaishi]

Jansa backport details:

$ git log -1
commit 915333f2077b83bd22c0bbcfae33d4622148aca5
Author: Oleg Barenboim <chessbyte@gmail.com>
Date:   Tue Oct 27 09:59:13 2020 -0400

    Merge pull request #946 from NickLaMuro/jansa_approved_test

    [requests/providers_spec.rb] Jansa approved spec

    (cherry picked from commit 4303f090cfc8aea7dedd28d3b5998670f2054925)

[simaishi]

Kasparov backport details:

$ git log -1
commit 70cb299b289f1d3f003d549b09aac2ecfff8fac7
Author: Oleg Barenboim <chessbyte@gmail.com>
Date:   Tue Oct 27 09:59:13 2020 -0400

    Merge pull request #946 from NickLaMuro/jansa_approved_test

    [requests/providers_spec.rb] Jansa approved spec

    (cherry picked from commit 4303f090cfc8aea7dedd28d3b5998670f2054925)