Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use shared tests from manageiq-providers-ansible_tower #15594

Merged
merged 3 commits into from
Jul 20, 2017
Merged

Use shared tests from manageiq-providers-ansible_tower #15594

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
950e16d
Backport? (copy) the applicable parts of "New Tower credential types"
bdunne Jul 19, 2017
9efea43
Use resources in manageiq-providers-ansible_tower for testing
bdunne Jul 18, 2017
8fea1b3
Remove ansible_shared examples that already exist in the provider plugin
bdunne Jul 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ def image_path(path, options = {})
# include the manageiq-gems-pending matchers
Dir[ManageIQ::Gems::Pending.root.join("spec/support/custom_matchers/*.rb")].each { |f| require f }

# To be extracted with embedded_ansible
require ManageIQ::Providers::AnsibleTower::Engine.root.join("spec/support/vcr_helper.rb").to_s
Dir[ManageIQ::Providers::AnsibleTower::Engine.root.join("spec/support/ansible_shared/**/*.rb")].each { |f| require f }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am 👍 for this as it's a very prescriptive change, and is clearly labeled to be moved when embedded_ansible is extracted.

RSpec.configure do |config|
config.expect_with :rspec do |c|
c.syntax = :expect
Expand Down