Skip to content

Commit

Permalink
[rails6] Use relative paths for layouts
Browse files Browse the repository at this point in the history
Fixes the following Deprecation warnings:

  DEPRECATION WARNING: Rendering layouts from an absolute path is deprecated.
  (called from render_pdf_internal_rr at /home/travis/build/ManageIQ/manageiq-ui-classic/app/controllers/application_controller/report_downloads.rb:47)

  DEPRECATION WARNING: Rendering layouts from an absolute path is deprecated.
  (called from print_report at /Users/nicklamuro/code/redhat/manageiq-ui-classic/app/controllers/application_controller/report_downloads.rb:124)

  DEPRECATION WARNING: Rendering layouts from an absolute path is deprecated.
  (called from set_summary_pdf_data at /home/travis/build/ManageIQ/manageiq-ui-classic/app/controllers/application_controller/report_downloads.rb:234)

Caused by the Rails 6.0 Upgrade
  • Loading branch information
NickLaMuro committed Jan 12, 2021
1 parent 911b628 commit 5c54c66
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions app/controllers/application_controller/report_downloads.rb
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ def render_pdf_internal(report)
def render_pdf_internal_rr(report, result)
@options = report_print_options(report, result) # used by the layouts/print
render(
:template => '/layouts/print/report',
:layout => '/layouts/print',
:template => 'layouts/print/report',
:layout => 'layouts/print',
:locals => {
:report => report,
:data => result.html_rows.join
Expand Down Expand Up @@ -122,8 +122,8 @@ def print_report

@options = report_print_options(result.report, result) # used by the layouts/print
render(
:template => '/layouts/print/report',
:layout => '/layouts/print',
:template => 'layouts/print/report',
:layout => 'layouts/print',
:locals => {
:report => result.report,
:data => result.html_rows.join
Expand Down Expand Up @@ -231,7 +231,7 @@ def set_summary_pdf_data
end

disable_client_cache
render :template => '/layouts/print/textual_summary', :layout => '/layouts/print'
render :template => 'layouts/print/textual_summary', :layout => 'layouts/print'
end
end
end

0 comments on commit 5c54c66

Please sign in to comment.