Upgrade from FactoryGirl to FactoryBot

[juliancheal]

No description provided.

[djberg96]

Hm, thought I did this already in #534. I guessed I missed one?

Ah, Libor added it in a485c9a#diff-7d8aa00e248fc954da2ec96ccc62faf3 after I had done the main change.

[kbrock]

  1) ConversionHosts API delete can delete a conversion host via DELETE
     Failure/Error: factory_exists?(factory) ? super : class_from_symbol(factory).create!(*args)
     
     ActiveRecord::RecordInvalid:
       Validation failed: ConversionHost: Resource Feature not available/supported
     # ./spec/manageiq/spec/support/missing_factory_helper.rb:10:in `create'

[djberg96]

@kbrock I'm not seeing that locally, though. Maybe @juliancheal needs to rebase?

[juliancheal]

Rebased :)

[djberg96]

Yeah, now you're seeing the same two errors that I saw locally.

[kbrock]

@juliancheal Looks like master had the same problem. This was fixed 20 hours ago - please re-kick

This error feels very unrelated

[miq-bot]

Checked commit https://github.com/juliancheal/manageiq-api/commit/e609822b5e7ab26ac167e8365bdaeb785290dc00 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍