Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix that "Rename and move file" throws file not found exception #4317

Merged
merged 3 commits into from
Sep 11, 2018
Merged

Fix that "Rename and move file" throws file not found exception #4317

merged 3 commits into from
Sep 11, 2018

Conversation

tobiasdiez
Copy link
Member

Fixes #4307. Moreover, I refactored a bit how files are renamed/moved to the default file directory. This should make it easier to reuse the code.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@tobiasdiez
Fix that "Rename and move file" throws file not found exception
dafd614 
Fixes #4307. Moreover, I refactored a bit how files are renamed/moved to the default file directory. This should make it easier to reuse the code.
@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 4, 2018
Siedlerchr
Siedlerchr reviewed Sep 4, 2018
View reviewed changes
src/main/java/org/jabref/gui/externalfiles/LinkedFileHandler.java Outdated
this.filePreferences = Objects.requireNonNull(filePreferences);
}

public boolean moveToDefaultDirectory() throws IOException {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why you duplicate the code of the moveFilesCleanup, is not necessary, as the moveFiles cleanup can also work with a single linked file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see you refactored this out of the cleanup, But you now have a architecture violation from logic to gui

@tobiasdiez
Copy link
Member Author

I'll merge this now so that progress on #4306 is not blocked.

@tobiasdiez tobiasdiez merged commit 4c3e520 into master Sep 11, 2018
@tobiasdiez tobiasdiez deleted the fix4307 branch September 11, 2018 08:56
Siedlerchr added a commit that referenced this pull request Sep 12, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into storeColumnSortOrder
5aad511 
* upstream/master:
  Fix that web search pane steals input (#4335)
  Fix entry editor field display (#4333)
  Convert update worker to BackgroundTask (#4334)
  Fix that "Rename and move file" throws file not found exception (#4317)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr left review comments

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasdiez @Siedlerchr