Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entry editor field display #4333

Merged
merged 3 commits into from
Sep 11, 2018
Merged

Conversation

tobiasdiez
Copy link
Member

Some of the entry editor fields were not using all the available height which resulted in an inhomogenous display. This is fixed now.
I also marked more fields as "singleline". Moreover, singleline fields are now vertically centered (I'm not sure if I like this change or not - but I couldn't find a way to make text in text fields not centered...).

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 11, 2018
@tobiasdiez tobiasdiez merged commit 8971a4f into master Sep 11, 2018
@tobiasdiez tobiasdiez deleted the fixEntryEditorFieldDisplay branch September 11, 2018 22:14
Siedlerchr added a commit that referenced this pull request Sep 12, 2018
* upstream/master:
  Fix that web search pane steals input (#4335)
  Fix entry editor field display (#4333)
  Convert update worker to BackgroundTask (#4334)
  Fix that "Rename and move file" throws file not found exception (#4317)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants