Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable rename when file has already right name #4306

Closed
tobiasdiez opened this issue Aug 31, 2018 · 3 comments
Closed

Disable rename when file has already right name #4306

tobiasdiez opened this issue Aug 31, 2018 · 3 comments
Labels
entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement

Comments

@tobiasdiez
Copy link
Member

Entry editor > File > Right click > "Rename" asks to "Overwrite the existing file" if the generated name is the same as the original one. That's a bit confusing. Better: just disable the option if the file already has the correct name.

Same applies to "Move" and "Rename and move"
@tobiasdiez tobiasdiez added type: enhancement entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. labels Aug 31, 2018
@ghost
Copy link

ghost commented Sep 8, 2018 •
edited by ghost
Loading

Is anyone working on this one @tobiasdiez ? If not can I see if I can fix it?

@tobiasdiez
Copy link
Member Author

@Arbalest007 Feel free to work on this issue! Also have a look at our contribution guide and feel free to drop by in our developer chat if you have questions!

For this issue, have a look at org.jabref.logic.externalfiles.LinkedFileHandler, which provides the method getSuggestedFileName that gives you the new file name. Essentially, it is enough to add a check in org.jabref.gui.fieldeditors.LinkedFilesEditor#createContextMenuForFile whether the suggested file name coincides with the current file name.

@tobiasdiez tobiasdiez mentioned this issue Sep 11, 2018
Merged
6 tasks
@ghost
Copy link

ghost commented Sep 11, 2018

Awesome @tobiasdiez! I'll get to work on it,

@ghost ghost mentioned this issue Sep 18, 2018
Closed
6 tasks
@RonakLakhotia RonakLakhotia mentioned this issue Mar 6, 2019
Merged
Siedlerchr pushed a commit that referenced this issue Mar 16, 2019
@RonakLakhotia @Arbalest007 @Siedlerchr
[#4306] Disable renaming (#4727)
d7dd41b 
* Disable renaming
* Fix issues


Co-authored-by: Patrick Lin <patrick.lin.007@hotmail.com>
Siedlerchr added a commit that referenced this issue Mar 16, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into isomedlineformatt…
2670bd1 
…erbibtexkey

* upstream/master: (827 commits)
  [#4306] Disable renaming (#4727)
  Feature: implement search filter in show preferences (#4759)
  Enable import button only if entry selected (#4761)
  Improve Remote messaging (#4760)
  Add changelog entry for #4520
  Modifications to improve contrast of UI elements (#4758)
  Rework external changes dialog in JavaFX (#4693)
  Changes the title of Group Dialog to Add subgroup when adding a new subgroup (#4757)
  Optimize data fetching (#4520)
  Adds a browse button next to the path text field for aux-based groups (#4743)
  Saving changes and exiting application (#4729)
  Code optimized and created a reusable method to get writer output (#4750)
  Bump mvvmfx from 1.7.0 to 1.8.0 (#4747)
  Bump guava from 27.0.1-jre to 27.1-jre (#4748)
  Bump mvvmfx-validation from 1.7.0 to 1.8.0 (#4749)
  Remove obsolete swing components in Preferences and OpenOffice (#4740)
  Move library specific key pattern dialog call to library menu (#4744)
  Revert "Revert "Fix: bibkey generated does not handle diacritics" (#4741)" (#4742)
  Revert "Fix: bibkey generated does not handle diacritics" (#4741)
  Rename method to removeUnwantedCharacters
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tobiasdiez