Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Sundials 6.6 behavior changes #1570

Merged
merged 6 commits into from
Aug 4, 2023
Merged

Fix for Sundials 6.6 behavior changes #1570

merged 6 commits into from
Aug 4, 2023

Commits on Aug 3, 2023

  1. [Reactor] Always use "one step" mode with SUNDIALS integrators 

    Do the interpolation required for "advance" explicitly, rather
than relying on SUNDIALS to do it as part of the call to CVode() or
IDASolve().

This circumvents a change in behavior introduced in SUNDIALS 6.6.

Fixes Cantera#1554.
    @speth
    speth committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    84a64e3 View commit details
    Browse the repository at this point in the history

  2. [CI] Test Sundials 6.6

    @speth
    speth committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    a8c57ee View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. [Reactor] Improve error message when advancing to past time 

    Resolves Cantera#1195
    @speth
    speth committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    1e55f64 View commit details
    Browse the repository at this point in the history

  2. [Reactor] Improve CVODES error handling 

    Include the name of the return code flag, not just its numeric value,
and the CVODES-generated error message for all errors.
    @speth
    speth committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    5a7c651 View commit details
    Browse the repository at this point in the history

  3. Mark Reactor/ReactorNet methods as const

    @speth
    speth committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    59625eb View commit details
    Browse the repository at this point in the history

  4. [Reactor] Fix getting sensitivities after calls to advance 

    Previously, values would be returned for the sensitivity at the
last internal timestep of the integrator, rather than being interpolated
to the user-specified integration time.
    @speth
    speth committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    652ed24 View commit details
    Browse the repository at this point in the history