Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change in Sundials 6.6 #1554

Closed
ischoegl opened this issue Jul 24, 2023 · 0 comments · Fixed by #1570
Closed

Breaking change in Sundials 6.6 #1554

ischoegl opened this issue Jul 24, 2023 · 0 comments · Fixed by #1570

Comments

@ischoegl
Copy link
Member

Sundials 6.6 is out with a breaking change:

Updated CVODE, CVODES and ARKODE default behavior when returning the solution when the internal time has reached a user-specified stop time. Previously, the output solution was interpolated to the value of tstop; the default is now to copy the internal solution vector. Users who wish to revert to interpolation may call a new routine
speth added a commit to speth/cantera that referenced this issue Aug 4, 2023
@speth
[Reactor] Always use "one step" mode with SUNDIALS integrators
84a64e3 
Do the interpolation required for "advance" explicitly, rather
than relying on SUNDIALS to do it as part of the call to CVode() or
IDASolve().

This circumvents a change in behavior introduced in SUNDIALS 6.6.

Fixes Cantera#1554.
@speth speth mentioned this issue Aug 4, 2023
Merged
5 tasks
ischoegl pushed a commit that referenced this issue Aug 4, 2023
@speth @ischoegl
[Reactor] Always use "one step" mode with SUNDIALS integrators
ce797ba 
Do the interpolation required for "advance" explicitly, rather
than relying on SUNDIALS to do it as part of the call to CVode() or
IDASolve().

This circumvents a change in behavior introduced in SUNDIALS 6.6.

Fixes #1554.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Cantera 3.0 Release Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for Sundials 6.6 behavior changes speth/cantera
1 participant
@ischoegl