-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Sundials 6.6 behavior changes #1570
Conversation
Do the interpolation required for "advance" explicitly, rather than relying on SUNDIALS to do it as part of the call to CVode() or IDASolve(). This circumvents a change in behavior introduced in SUNDIALS 6.6. Fixes Cantera#1554.
Include the name of the return code flag, not just its numeric value, and the CVODES-generated error message for all errors.
Codecov Report
@@ Coverage Diff @@
## main #1570 +/- ##
==========================================
+ Coverage 70.45% 70.51% +0.05%
==========================================
Files 379 379
Lines 59093 59112 +19
Branches 21230 21232 +2
==========================================
+ Hits 41636 41682 +46
+ Misses 14376 14354 -22
+ Partials 3081 3076 -5
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Previously, values would be returned for the sensitivity at the last internal timestep of the integrator, rather than being interpolated to the user-specified integration time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Changes proposed in this pull request
CV_NORMAL
/IDA_NORMAL
integration option which has a breaking change in behavior starting with SUNDIALS 6.6.Reactor
andReactorNet
methods asconst
where possibleReactorNet.advance
to use interpolation correctlyIf applicable, fill in the issue number this pull request is fixing
Resolves #1554
Resolves #1195
Checklist
scons build
&scons test
) and unit tests address code coverage