Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Sundials 6.6 behavior changes #1570

Merged
merged 6 commits into from
Aug 4, 2023

[Reactor] Fix getting sensitivities after calls to advance

652ed24
Select commit
Loading
Failed to load commit list.
Merged

Fix for Sundials 6.6 behavior changes #1570

[Reactor] Fix getting sensitivities after calls to advance
652ed24
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 4, 2023 in 0s

70.51% (+0.05%) compared to 6ba497c

View this Pull Request on Codecov

70.51% (+0.05%) compared to 6ba497c

Details

Codecov Report

Merging #1570 (652ed24) into main (6ba497c) will increase coverage by 0.05%.
Report is 3 commits behind head on main.
The diff coverage is 84.14%.

@@            Coverage Diff             @@
##             main    #1570      +/-   ##
==========================================
+ Coverage   70.45%   70.51%   +0.05%     
==========================================
  Files         379      379              
  Lines       59093    59112      +19     
  Branches    21230    21232       +2     
==========================================
+ Hits        41636    41682      +46     
+ Misses      14376    14354      -22     
+ Partials     3081     3076       -5     
Files Changed Coverage Δ
include/cantera/numerics/CVodesIntegrator.h 31.25% <ø> (ø)
include/cantera/numerics/IdasIntegrator.h 0.00% <ø> (ø)
src/zeroD/Reactor.cpp 85.47% <50.00%> (ø)
src/numerics/CVodesIntegrator.cpp 71.65% <75.55%> (+5.71%) ⬆️
src/numerics/IdasIntegrator.cpp 72.16% <95.83%> (+1.41%) ⬆️
include/cantera/kinetics/ImplicitSurfChem.h 100.00% <100.00%> (ø)
include/cantera/numerics/FuncEval.h 42.85% <100.00%> (ø)
include/cantera/zeroD/Reactor.h 61.76% <100.00%> (ø)
include/cantera/zeroD/ReactorNet.h 76.66% <100.00%> (ø)
src/zeroD/ReactorNet.cpp 81.21% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more