Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing Toolkit: Update to 2.8.10 #47969

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Editing Toolkit: Update to 2.8.10 #47969

merged 1 commit into from
Dec 2, 2020

Conversation

stacimc
Copy link
Contributor

@stacimc stacimc commented Dec 2, 2020

Changes proposed in this Pull Request

  • Bumps version of Editing Toolkit to 2.8.10

Changes included in this release

Testing instructions

  1. Load the diff on your sandbox (D53662-code) and confirm that the above changes work correctly
  2. Test that the new version of the plugin doesn't break Atomic sites by following the instructions in the "Atomic Testing" section at PCYsg-ly5-p2.

@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D53662-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

@stacimc stacimc self-assigned this Dec 2, 2020
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 2, 2020
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@noahtallen
Copy link
Contributor

btw, the phpunit failure is expected, unfortunately.

Otherwise, I don't think the NodeJS upgrade should affect much 👍

@apeatling
Copy link
Member

I've tested all the changes here, and they work fine on simple sites. Checking Atomic.

@ockham ockham mentioned this pull request Dec 2, 2020
31 tasks
@apeatling
Copy link
Member

Confirmed on Atomic sites too.

Copy link
Member

@p-jackson p-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested that Ramon and my changes are included and working on Atomic and Simple.

@apeatling apeatling merged commit 0a218d7 into trunk Dec 2, 2020
@apeatling apeatling deleted the release/etk-2.8.10 branch December 2, 2020 22:41
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants