Coming Soon: check for coming soon mode on 404 #47945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st's visibility in the editor, by switching the post status to private. Individual private posts are not available at all to the public and will 404. Here we're letting 404s through so we can check if coming soon is enabled.
ramonjd
added
[Status] Needs Review
lsl
approved these changes
Dec 2, 2020
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
andrewserong
approved these changes
Dec 2, 2020
|
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D53604-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Hi!
In this PR we are adding an
is404(), after which we'll decide whether to show the coming soon page.This primarily captures the case where the user edits the post's visibility in the editor by switching the post status to private.
Individual private posts are not available at all to the public and will 404.
More information: https://wordpress.org/support/article/content-visibility/
Props to @charliescheer and @katiebethbrown for alerting us to this!
Testing instructions
Checkout this branch
Run
yarn dev --syncinapps/editing-toolkitSandbox a test site. Ensure that site is launched.
Enable Coming Soon mode over at
/settings/general/{your_site}Now head to any post or page, and make that individual post/page private
Visit this page in an incognito browser
You should see the Coming Soon page