Gutenberg: 9.4 Plugin Upgrade

[fullofcaffeine]

Previous upgrade: #47011

Process

• Install and activate on edge sites
  • Copy 9.3.0 to 9.4 RC1 (D52898-code and D52900-code)
  • Activate 9.4 RC1 on edge (D52901-code)
  • Install 9.4 plugin version
• Testing
  • Calypso e2e (Gutenberg: Fixes for Gutenberg v9.4.1 #47533)
  • TC (D52936-code)
• Update to stable release
• Update to 9.4.1 point release
• Activate upgrade for all sites (D52936-code)
• Request update for Atomic sites (p9o2xV-1az-p2)
• Publish internal announcements (p7DVsv-9Ya-p2)
• Clean up unused releases
  • 9.1.1
  • 9.4.0
• Open a new issue for the next upgrade, transfer remaining tasks, close this issue.
• Update the Log of Update Attempts at coGjb-p2 and list patches applied

Blocker

Note that we can't update on Atomic sites until JP 9.2 is released (and installed there) -- otherwise, we'll break JP blocks on FF: Automattic/jetpack#17850
Update: JP 9.2 was released on 2020-12-01, so we proceeded and also landed the GB upgrade.

Tasks / potential blockers 🐛

• Browser locks up upon adding a columns block (Gutenberg Edge: Tab/browser locks up upon adding a columns block #47579)
• Jetpack blocks not loaded / found in the inserter on Firefox (Jetpack blocks not being loaded/found on Gutenberg 9.4 on WPCOM/AT when using Firefox jetpack#17850) (p1605902623138500-slack-C015AL3QL7M)
• With 9.4.0 RC1, template parts are no longer loading.
  • Reported in p1605706934011400-slack-CHN6J22MP (for a WP.com edge site, PczmP1-2-p2).
  • Upstream issue: Template parts do not load in the full-site editor.  WordPress/gutenberg#27072.
  • Seems to be okay, as it only affects previously created FSE sites -- which currently aren't public. See Template parts do not load in the full-site editor.  WordPress/gutenberg#27072 (comment) for more details.

Open issues (post-release)

• With 9.4, the 'Publish' button now reads 'Schedule...'. (Reported at Editor: Publish button changes to Schedule if site is UCT+0 #47935, Date: Site date formats may crash the editor WordPress/gutenberg#27514, “Schedule” displaying instead of “Publish” on new posts/pages WordPress/gutenberg#27251, and Date: Tests are false-positive, assumes it is ran in GMT timezone and en_US locale WordPress/gutenberg#27500.)
  • Potential fixes at Refactor date functions to reflect expected test results WordPress/gutenberg#27398 and Date package: Fix timezone issues WordPress/gutenberg#27519.
  • Decided to fix through a revert (Revert date changes from branch 'replace-moment' WordPress/gutenberg#27550). See Revert date changes from branch 'replace-moment' WordPress/gutenberg#27550 (comment) for more context.
  • Needs a GB point release.
• [Premium Content Block] Issues with multiple pricing plans ([Premium Content Block] Issues with multiple pricing plans #47939)
  • Fix: Correctly sync planId between PremiumContent and Payments block #47944
  • Needs ETP release (Editing Toolkit: Update to 2.8.10 #47969)
• Adding a new page and trying to select one of the page templates (from our WordPress.com Editing Toolkit plugin) causes the editor/template preview to crash every time. (p1606867460319700-slack-C015AL3QL7M)
  • Fix: Popover: Fix issue with undefined getBoundingClientRect WordPress/gutenberg#27445
  • Needs Gutenberg (patch) release, or further investigation what changed in Calypso that cause this to happen.
• Users can no longer see the WooCommerce Payments pages under WP-Admin > Payments. (p9F6qB-6dU-p2 and p1606927004322300-slack-CGGCLBN58)

[sirreal]

Release notes: https://make.wordpress.org/core/2020/11/19/whats-new-in-gutenberg-4-november-2/

[aleone89]

Crosslinking: #47579

cc. @getdave

[sirreal]

Adding a new page and trying to select one of the page templates (from our WordPress.com Editing Toolkit plugin) causes the editor/template preview to crash every time. (p1606867460319700-slack-C015AL3QL7M and WordPress/gutenberg#27445)

Diff here for testing: D53653-code

[fullofcaffeine]

This is done. Next one: #47881.