Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another attempt at alignments #4459

Merged
merged 12 commits into from
Aug 24, 2021
Merged

Another attempt at alignments #4459

merged 12 commits into from
Aug 24, 2021

Conversation

pbking
Copy link
Contributor

@pbking pbking commented Aug 23, 2021

WIP...

@pbking pbking marked this pull request as draft August 23, 2021 21:16
@scruffian
Copy link
Member

It would be useful to document the different cases this is trying to address...

@pbking
Copy link
Contributor Author

pbking commented Aug 24, 2021

They are documented here: pcrugM-lB-p2

pbking and others added 3 commits August 24, 2021 07:52
fix pelling istake

Co-authored-by: Ben Dwyer <ben@scruffian.com>
…applying the page-level padding differently.
@pbking pbking marked this pull request as ready for review August 24, 2021 17:09
Copy link
Contributor

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

coreymckrill added a commit to WordPress/wporg-news-2021 that referenced this pull request Sep 9, 2021
This better accommodates the change in Gutenberg that causes all blocks
that support `experimentalLayout` (the Group block) to get the
`wp-container-[hash]` class added during rendering.

See Automattic/themes#4459
coreymckrill added a commit to WordPress/wporg-news-2021 that referenced this pull request Sep 9, 2021
* Bring over the layout/alignment style changes from Blockbase
  This better accommodates the change in Gutenberg that causes all blocks that support `experimentalLayout` (the Group block) to get the `wp-container-[hash]` class added during rendering.
  See Automattic/themes#4459
* Set the post header's layout to flex
* Tweak layout styles to restore desired alignments
* Avoid using 'important' clauses where possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Blockbase Alignments
3 participants