Fixes for breaking changes from Gutenberg 11.4 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This better accommodates the change in Gutenberg that causes all blocks that support `experimentalLayout` (the Group block) to get the `wp-container-[hash]` class added during rendering. See Automattic/themes#4459
iandunn
approved these changes
Sep 9, 2021
iandunn
reviewed
Sep 9, 2021
source/wp-content/themes/wporg-news-2021/sass/blocks/_post-title.scss
Outdated
Show resolved
Hide resolved
iandunn
reviewed
Sep 9, 2021
source/wp-content/themes/wporg-news-2021/sass/post/_header.scss
Outdated
Show resolved
Hide resolved
|
@iandunn Do you want to address the global header margins in the PR, or in a separate one? Here's what it's looking like right now:
|
|
I'll take care of it in #28 , I've got it mostly working locally, but am playing around with a few approaches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our theme had some alignment styles from Blockbase that didn't play well with changes introduced in Gutenberg 11.4. I went and found the commit where Blockbase was fixed to accommodate those changes and brought it over, and it seems to mostly fix the problem described in #29.
This is still a bit of a work-in-progress as I try to figure out if I can avoid introducing more
!importantclauses to the stylesheet, but I wanted to get your eyes on this @iandunn because it also appears to affect the global header (currently it's getting some margin added on the sides instead of being full-width).