Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Blockbase Alignments #4456

Closed
pbking opened this issue Aug 23, 2021 · 1 comment · Fixed by #4459
Closed

Refactor Blockbase Alignments #4456

pbking opened this issue Aug 23, 2021 · 1 comment · Fixed by #4459
Labels
[Theme] Blockbase

Comments

@pbking
Copy link
Contributor

pbking commented Aug 23, 2021

Due to recent changes in Gutenberg that brought the 'container-' class to all containers this can no longer be leveraged to help control Blockbase alignments.

How blockbase is configuring and managing alignment state needs to be revisited.

Related:

#4435 (noted alignment + Global Styles clobbering issues with Cover and Group blocks)
#4448 (a potential fix to the issue that was causing pain in Skatepark)
#4454 (Removes alignment styling and gets out of the alignment ponyfill game)
@pbking pbking mentioned this issue Aug 23, 2021
Closed
@pbking pbking mentioned this issue Aug 23, 2021
Closed
@pbking pbking linked a pull request Aug 24, 2021 that will close this issue
Another attempt at alignments #4459
Merged
@pbking
Copy link
Contributor Author

pbking commented Aug 24, 2021

Completed in #4459.

@pbking pbking closed this as completed Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Theme] Blockbase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Another attempt at alignments Automattic/themes
1 participant
@pbking