Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating a non-existent record should return HTTP error 404 and not 400 #379

Conversation

QuantumDancer
Copy link
Collaborator

This fixes #378

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Merging #379 (c51e60e) into main (ec426b1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #379   +/-   ##
=======================================
  Coverage   56.80%   56.80%           
=======================================
  Files          42       42           
  Lines        3702     3702           
  Branches       50       50           
=======================================
  Hits         2103     2103           
  Misses       1599     1599           
Components Coverage Δ
apel_plugin 65.02% <ø> (ø)
auditor 82.40% <ø> (ø)
slurm_collector 30.88% <ø> (ø)
slurm_epilog_collector 0.00% <ø> (ø)
priority_plugin 51.47% <ø> (ø)

@QuantumDancer QuantumDancer force-pushed the updating-nonexisting-record-404 branch from c51e60e to 414c3e1 Compare August 7, 2023 13:43
@QuantumDancer QuantumDancer enabled auto-merge (rebase) August 7, 2023 13:43
@QuantumDancer QuantumDancer enabled auto-merge (rebase) August 7, 2023 14:10
@QuantumDancer QuantumDancer merged commit a59bf5f into ALU-Schumacher:main Aug 7, 2023
37 checks passed
@QuantumDancer QuantumDancer deleted the updating-nonexisting-record-404 branch November 17, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating a non-existent record should return HTTP error 404 and not 400
3 participants