Breaking change: Updating a non-existent record should return HTTP er…

…ror 404 and not 400 This fixes #378
ALU-Schumacher · Aug 7, 2023 · 414c3e1 · 414c3e1
1 parent 5bc1e2e
commit 414c3e1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/auditor/src/routes/update.rs b/auditor/src/routes/update.rs
@@ -22,7 +22,7 @@ pub enum UpdateError {
 debug_for_error!(UpdateError);
 responseerror_for_error!(
     UpdateError,
-    UnknownRecord => BAD_REQUEST;
+    UnknownRecord => NOT_FOUND;
     UnexpectedError => INTERNAL_SERVER_ERROR;
 );
 

diff --git a/auditor/tests/api/update.rs b/auditor/tests/api/update.rs
@@ -3,7 +3,7 @@ use auditor::domain::{Component, Record, RecordDatabase, RecordTest};
 use fake::{Fake, Faker};
 
 #[tokio::test]
-async fn update_returns_a_400_for_non_existing_record() {
+async fn update_returns_a_404_for_non_existing_record() {
     // Arange
     let app = spawn_app().await;
     let client = reqwest::Client::new();
@@ -19,7 +19,7 @@ async fn update_returns_a_400_for_non_existing_record() {
         .await
         .expect("Failed to execute request.");
 
-    assert_eq!(400, response.status().as_u16());
+    assert_eq!(404, response.status().as_u16());
 }
 
 #[tokio::test]