Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you please compile the win32 arm32 version too (for unlocked W8.1 RT arm32)? #134

Closed
easyentry opened this issue Oct 14, 2019 · 20 comments

Comments

@easyentry
Copy link

Hello,

I am no coder, so could you please help me:
Could you please compile the win32 arm32 version too (for unlocked W8.1 RT and W8.0 RT arm32)?
It will be great to see Notepad2 running there.

@zufuliu
Copy link
Owner

zufuliu commented Oct 15, 2019

The build configuration is added.

You can find prebuild artifacts in job
Environment: compiler=MSVC; Configuration: Release; Platform: ARM
at https://ci.appveyor.com/project/zufuliu/notepad2
e.g.:
https://ci.appveyor.com/project/zufuliu/notepad2/build/job/pstdxnju222xj73e/artifacts

@easyentry
Copy link
Author

Great. Thanks.
Please, could you also add arm32 binaries ZIP to the releases section on GitHub?

@easyentry
Copy link
Author

here is the invite for my Windows on arm64 and arm32 Discord group:
https://discord.gg/amkHrtW

@easyentry
Copy link
Author

It ALMOST works on arm32 RT (W8-1):
http://www.technique.cz/storage/Notepad2.jpg
Still, great progress.

@easyentry
Copy link
Author

On W10 arm64 both arm64 and arm32 binaries work:
http://www.technique.cz/storage/Notepad2_10.jpg

@zufuliu
Copy link
Owner

zufuliu commented Oct 15, 2019

Hi @easyentry, can you also test whether the Clang ARM64 build works on Win10 arm64?

artificial in job Environment: compiler=Clang; Configuration: Release; Platform: ARM64 like
https://ci.appveyor.com/project/zufuliu/notepad2/build/job/7i50fel1wwuge2uj/artifacts

@easyentry
Copy link
Author

Clang arm64 binary works too on W10 arm64.

@easyentry
Copy link
Author

Do you want me to run Debugger with !analyze -v on RT (W8-1) and paste the output?

@zufuliu
Copy link
Owner

zufuliu commented Oct 15, 2019

@easyentry Thanks.
How about change Settings -> Rendering Technology to "Legacy GDI"

@easyentry
Copy link
Author

@zufuliu yep, that works. but RT should have DirectDraw/2d support too.
What is your email btw?

@zufuliu
Copy link
Owner

zufuliu commented Oct 16, 2019

I think it's maybe color font / Emoji that cause the drawing bug.
https://sourceforge.net/p/scintilla/feature-requests/1277/

If you have Visual Stdio 2017/2019 you can try change d2dDrawTextOptions to D2D1_DRAW_TEXT_OPTIONS_NONE
https://github.com/zufuliu/notepad2/blob/master/scintilla/win32/PlatWin.cxx#L138

@zufuliu
Copy link
Owner

zufuliu commented Oct 16, 2019

@easyentry Please check whether the attached file works or not, it build without color font option.
Notepad2_ARM_D2D_NONE.zip

@easyentry
Copy link
Author

Notepad2_ARM_D2D_NONE.zip is the same as is normal version.

BTW: Options Direct2D Retain and Direct2D GDI DC work (on any version of Notepad2).

@zufuliu
Copy link
Owner

zufuliu commented Oct 16, 2019

Is Direct2D Retain/ Direct2D GDI DC support emoji like 😊

If Direct2D Retain and Direct2D GDI DC works, then it's better to change the default rendering technology for ARM32 to Direct2D Retain or Direct2D GDI DC instead of Direct2D.

@easyentry
Copy link
Author

Good, I will try to yet play with it to gather more information.

@zufuliu
Copy link
Owner

zufuliu commented Oct 16, 2019

From Scintilla document at
https://www.scintilla.org/ScintillaDoc.html#SCI_SETTECHNOLOGY

SC_TECHNOLOGY_DIRECTWRITERETAIN differs from SC_TECHNOLOGY_DIRECTWRITE by requesting that the frame is retained after being presented which may prevent drawing failures on some cards and drivers.

It might a card.driver issue.

@easyentry
Copy link
Author

So retain mode is kind of fix. :)

@easyentry
Copy link
Author

easyentry commented Oct 16, 2019

I have a Nokia Lumia 2520, which has Qualcomm SnapDragon 800.
It would be nice to check with somebody, who has Surface 1 / 2 (RT) with nVidia Tegra.

@zufuliu
Copy link
Owner

zufuliu commented Oct 20, 2019

ARM32 build is added in release list for v4.19.10r2454, I consider this as been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants