Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you like to have a Windows ARM64 port? #56

Closed
Biswa96 opened this issue Mar 22, 2020 · 6 comments
Closed

Would you like to have a Windows ARM64 port? #56

Biswa96 opened this issue Mar 22, 2020 · 6 comments

Comments

@Biswa96
Copy link

Biswa96 commented Mar 22, 2020

No description provided.

@stefankueng
Copy link
Owner

building for ARM64 isn't a problem. But testing - don't have an ARM64 machine.

stefankueng added a commit that referenced this issue Apr 7, 2020
@Biswa96
Copy link
Author

Biswa96 commented Apr 7, 2020

Some errors are shown in VS19:

BowPad\src\last\version.h(7) : Info : Run the NAnt script to get proper version info
LINK : warning LNK4217: symbol 'CoolSB_SetScrollInfo' defined in 'coolsb.lib(coolsblib.obj)' is imported by 'Scintilla.lib(ScintillaWin.obj)' in function '"private: int __cdecl ScintillaWin::CoolSB_SetScrollInfo(int,struct tagSCROLLINFO const *,int)" (?CoolSB_SetScrollInfo@ScintillaWin@@AEAAHHPEBUtagSCROLLINFO@@H@Z)'
LINK : warning LNK4217: symbol 'CoolSB_GetScrollInfo' defined in 'coolsb.lib(coolsblib.obj)' is imported by 'Scintilla.lib(ScintillaWin.obj)' in function '"private: bool __cdecl ScintillaWin::CoolSB_GetScrollInfo(int,struct tagSCROLLINFO *)" (?CoolSB_GetScrollInfo@ScintillaWin@@AEAA_NHPEAUtagSCROLLINFO@@@Z)'

While compiling the ARM64 version, the executable is linked with comctl32 in WinSxS instead of system32, any solution?

C:\Windows\WinSxs\amd64_microsoft.windows.common-controls_6595b64144ccf1df_6.0.19569.1000_none_6e34fb0e2d4dc0f9\comctl32.dll

@stefankueng
Copy link
Owner

the version.h info means that your build uses the default version.h file which does not have the proper version numbers in it but "0.0.0.0".

the link warnings can be ignored and come from the custom scrollbar we use.

as for comctl32 - why should it not use the one in WinSxS?

@stefankueng
Copy link
Owner

add an

#if defined(_M_IX86) || defined(_M_X64)
// pragma
#endif

around the pragma in stdafx.h

@zufuliu
Copy link

zufuliu commented Apr 13, 2020

Scintilla it self works well on ARM64 (Windows 10) and ARM32 (Windows 10 on ARM64, and the discontinued Windows RT) without any code changes.
See zufuliu/notepad4#134 (see comments, SC_TECHNOLOGY_DIRECTWRITERETAIN is used as default on ARM32)
https://sourceforge.net/p/scintilla/feature-requests/1319/

@Biswa96
Copy link
Author

Biswa96 commented Jul 13, 2020

Apology for late reply. I have tested BowPad ARM64 latest master branch (as of today) in Windows 10 ARM64 build 20161. It works without any issue. Thank you ❤️

@Biswa96 Biswa96 closed this as completed Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants