Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust pre-commit CI config #3345

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

TheJulianJES
Copy link
Collaborator

@TheJulianJES TheJulianJES commented Sep 2, 2024

Proposed change

This adjusts the title of future pre-commit CI auto-update PRs from "[pre-commit.ci] pre-commit autoupdate" to "Auto-update pre-commit hooks". This matches the current commit message of ZHA's pre-commit auto-update workflow and also aligns closer with how we/HA are naming PRs.
The auto-fix message (for commits on PRs that didn't run pre-commit first) has been changed to "Apply pre-commit auto fixes".

mypy is also dropped from the pre-commit CI action, as we're already doing this in our own CI flow with pre-commit.

Additional information

See an example auto-update PR from pre-commit CI here:

Related PR on the ZHA repo:

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.49%. Comparing base (77cc0d0) to head (3de3c60).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3345   +/-   ##
=======================================
  Coverage   88.49%   88.49%           
=======================================
  Files         305      305           
  Lines        9621     9621           
=======================================
  Hits         8514     8514           
  Misses       1107     1107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES merged commit ac96630 into zigpy:dev Sep 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant