Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust pre-commit CI config #192

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

TheJulianJES
Copy link
Contributor

@TheJulianJES TheJulianJES commented Sep 2, 2024

Proposed change

This slightly adjusts the commit messages for pre-commit CI.
mypy is also dropped from the pre-commit CI action, as we're already doing this in our own CI flow with pre-commit.

Additional information

Whilst pre-commit CI doesn't need any configuration and is already functional now, this PR updates the commit messages for auto-fixes (applied on PRs that didn't run pre-commit first) and the title of PRs created when the hooks are updated.

For auto-updates, this was "[pre-commit.ci] pre-commit autoupdate" before, but that doesn't really fit with how we/HA are naming PRs. For auto-fixes, it's "[pre-commit.ci] auto fixes from pre-commit.com hooks [...]" by default.
This PR changes it to more simple commit messages without a "[pre-commit.ci]" prefix.

Related PR on the quirks repo (same changes):

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (9f8263a) to head (9608aaa).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #192   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files          61       61           
  Lines        9404     9404           
=======================================
  Hits         9018     9018           
  Misses        386      386           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmulcahey dmulcahey merged commit c6edfd4 into zigpy:dev Sep 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants