Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump codespell to 2.3.0 #3257

Merged
merged 7 commits into from
Aug 11, 2024
Merged

Bump codespell to 2.3.0 #3257

merged 7 commits into from
Aug 11, 2024

Conversation

evie404
Copy link
Contributor

@evie404 evie404 commented Jul 16, 2024

Proposed change

Trying to update codespell to help #2336 ship. There are some issues using codespell 2.3.0 on the dev branch which this PR attempts to fix.

Additional information

none

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@evie404 evie404 changed the title Epai/fix codespells Fix codespell issues with 2.3.0 Jul 16, 2024
@evie404
Copy link
Contributor Author

evie404 commented Jul 16, 2024

keep getting this issue in CI :/

Different tests were collected between gw0 and gw3. The difference is:

@evie404 evie404 mentioned this pull request Jul 16, 2024
3 tasks
@evie404
Copy link
Contributor Author

evie404 commented Jul 16, 2024

Fix for broken CI: #3258

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.18%. Comparing base (b468717) to head (54a1593).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3257   +/-   ##
=======================================
  Coverage   88.18%   88.18%           
=======================================
  Files         301      301           
  Lines        9412     9412           
=======================================
  Hits         8300     8300           
  Misses       1112     1112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evie404 evie404 marked this pull request as ready for review August 2, 2024 23:19
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this should be fine.

@TheJulianJES TheJulianJES added the needs final review PR is ready for a final review from a maintainer label Aug 3, 2024
@TheJulianJES TheJulianJES changed the title Fix codespell issues with 2.3.0 Bump codespell to 2.3.0 Aug 11, 2024
@TheJulianJES TheJulianJES merged commit 7536a4f into zigpy:dev Aug 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs final review PR is ready for a final review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants