Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI build issues on dev branch #3258

Closed
wants to merge 2 commits into from
Closed

Conversation

evie404
Copy link
Contributor

@evie404 evie404 commented Jul 16, 2024

Proposed change

While working on unrelated change (#3257), I found CI is broken due to upstream changes in test setup: zigpy/workflows@248b545

Pinning workflow to the commit before the breaking change.

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.18%. Comparing base (8317dc6) to head (8abc1d2).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3258   +/-   ##
=======================================
  Coverage   88.18%   88.18%           
=======================================
  Files         301      301           
  Lines        9412     9412           
=======================================
  Hits         8300     8300           
  Misses       1112     1112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evie404 evie404 changed the title debug and fix build issues on dev branch fix build issues on dev branch Jul 16, 2024
@evie404 evie404 changed the title fix build issues on dev branch fix CI build issues on dev branch Jul 16, 2024
@evie404 evie404 marked this pull request as ready for review July 16, 2024 10:34
@evie404 evie404 mentioned this pull request Jul 16, 2024
3 tasks
@TheJulianJES
Copy link
Collaborator

TheJulianJES commented Jul 29, 2024

Thanks for the PR!
We'll go with this PR for fixing CI and keeping xdist:

If you want, feel free to PR your README changes separately.

@evie404 evie404 deleted the epai/fix_ci branch August 2, 2024 23:20
@evie404
Copy link
Contributor Author

evie404 commented Aug 2, 2024

ty for fixing the dev branch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants