-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve grouping with groupRows. closes #294 #297
Conversation
…copy&pasted over everything until I found the expected values in my xml file.
If this passes the checks (did not check prio to pushing) this needs some testing. I have made changes to the write function and got mad and did not try to fully understand the old code. Also I was not entirely sure how to handle grouping, because I do not really use it and therefore might have implemented changes that are unwanted/unneeded. Checked basic functionality with LO and MS 365. |
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
==========================================
+ Coverage 66.48% 66.49% +0.01%
==========================================
Files 34 34
Lines 8939 8942 +3
==========================================
+ Hits 5943 5946 +3
Misses 2996 2996
Continue to review full report at Codecov.
|
I figured out what I needed to with the old groupRows function. For the iris df, to group on the first instance of each Species in the xlsx file, the following code works for what I need. groupRows(wb, sheet=1, c(2:51,53:101,103:151)) One just needs to play around with it a bit, and understand the shifting of rows going from the df to xlsx, and how Excel groups things on its side. Thanks, Burgess |
Thanks for the follow up. I kinda figured the same when creating this pull request. You can't have different grouped rows in the same outline that are attached to each other. Excel will automatically combine both. To avoid this, you need to skip at least one row. Though this pull request allows having multiple nested groups and it fixes the previous warning message. |
c892789
to
c014f24
Compare
darn, I got lost with open pull requests (293 != 294) anyone got a copy of this branch lying around? 😄 |
c014f24
to
50eac9f
Compare
allow different grouping options for
groupRows()
. Needs testing due possible breaking changes towrite_file_2.cpp
.