Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to blocks documentation #199

Merged
merged 1 commit into from
Jan 31, 2019

Conversation

ajitbohra
Copy link
Contributor

Fixes dead links.

@gziolo
Copy link
Contributor

gziolo commented Jan 29, 2019

Looks great, all links work properly. I can't accept officially, but 👍 from me.

Should we include the link to JavaScript in WordPress tutorial which was added to the handbook recently:
https://wordpress.org/gutenberg/handbook/designers-developers/developers/tutorials/javascript/

I'm not quite sure, it might be good for those not familiar with JavaScript but fluent in PHP.

@ajitbohra
Copy link
Contributor Author

Sounds good, we can add this link in the php template, will help people easily discover tutorials.

Or maybe we can add the link to tutorial landing in both JS and PHP template https://wordpress.org/gutenberg/handbook/designers-developers/developers/tutorials/

Whats the best place to add the link ?

@schlessera
Copy link
Member

I'm not sure, but I'd say the link to the JavaScript tutorial seems out of scope here.

@schlessera
Copy link
Member

I'll merge this as-is for now. We can still discuss adding JavaScript tutorials in a separate issue if you feel this is needed.

@schlessera schlessera added this to the 2.0.5 milestone Jan 31, 2019
@schlessera schlessera merged commit 735e626 into wp-cli:master Jan 31, 2019
@schlessera
Copy link
Member

Thanks for the PR, @ajitbohra!

@gziolo
Copy link
Contributor

gziolo commented Jan 31, 2019

I'll merge this as-is for now. We can still discuss adding JavaScript tutorials in a separate issue if you feel this is needed.

It wouldn't harm to add it somewhere, but it also isn't essential for the success of understanding the code generated. Totally optional in my opinion.

danielbachhuber pushed a commit that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants