Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update links #13531

Merged
merged 10 commits into from
Jan 29, 2019
Merged

Docs: update links #13531

merged 10 commits into from
Jan 29, 2019

Conversation

ajitbohra
Copy link
Member

@ajitbohra ajitbohra requested a review from gziolo January 27, 2019 22:46
@chrisvanpatten
Copy link
Member

🙌

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I shared some suggestions on how to fix the broken links I found.

test/integration/full-content/fixtures/README.md Outdated Show resolved Hide resolved
test/integration/full-content/fixtures/README.md Outdated Show resolved Hide resolved
@@ -66,7 +66,7 @@ The core provided categories are:
category: 'widgets',
```

Plugins and Themes can also register [custom block categories](../docs/extensibility/extending-blocks/#managing-block-categories).
Plugins and Themes can also register [custom block categories](/docs/extensibility/extending-blocks/#managing-block-categories).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All link updated in this file seem to be outdated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's referring to the old structure.

@gziolo
Copy link
Member

gziolo commented Jan 28, 2019

Nice one @ajitbohra - it would be great to land it soon to have one way to link everywhere 💯

@gziolo gziolo added the [Type] Developer Documentation Documentation for developers label Jan 28, 2019
@gziolo gziolo added this to the Documentation & Handbook milestone Jan 28, 2019
gziolo and others added 6 commits January 29, 2019 00:21
Co-Authored-By: ajitbohra <ajit@lubus.in>
Co-Authored-By: ajitbohra <ajit@lubus.in>
Co-Authored-By: ajitbohra <ajit@lubus.in>
Co-Authored-By: ajitbohra <ajit@lubus.in>
Co-Authored-By: ajitbohra <ajit@lubus.in>
@ajitbohra
Copy link
Member Author

ajitbohra commented Jan 28, 2019

@gziolo refactored links at few more places & fixed dead links across docs. We have been referring to the old structure.

@@ -62,7 +62,7 @@ This will generate 4 files inside the `movies` plugin directory. All files conta
* Registers all block assets so that they can be enqueued through Gutenberg in
* the corresponding context.
*
* @see https://wordpress.org/gutenberg/handbook/blocks/writing-your-first-block-type/#enqueuing-block-scripts
* @see https://wordpress.org/gutenberg/handbook/designers-developers/developers/tutorials/block-tutorial/writing-your-first-block-type/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should backport those changes to WP-CLI, too :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed my own comments in commits :)

Great work on this one. Thank you very much for leading those efforts 💯

docs/contributors/scripts.md Outdated Show resolved Hide resolved
docs/contributors/scripts.md Outdated Show resolved Hide resolved
@gziolo gziolo merged commit 9e523ce into master Jan 29, 2019
@gziolo gziolo deleted the docs/update-links branch January 29, 2019 09:02
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
* Docs: update links

* Update link

Co-Authored-By: ajitbohra <ajit@lubus.in>

* Update link

Co-Authored-By: ajitbohra <ajit@lubus.in>

* Update link

Co-Authored-By: ajitbohra <ajit@lubus.in>

* Update link

Co-Authored-By: ajitbohra <ajit@lubus.in>

* Update link

Co-Authored-By: ajitbohra <ajit@lubus.in>

* Update & fix dead links

* Update README.md

* Update writing-your-first-block-type.md

* Update scripts.md
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
* Docs: update links

* Update link

Co-Authored-By: ajitbohra <ajit@lubus.in>

* Update link

Co-Authored-By: ajitbohra <ajit@lubus.in>

* Update link

Co-Authored-By: ajitbohra <ajit@lubus.in>

* Update link

Co-Authored-By: ajitbohra <ajit@lubus.in>

* Update link

Co-Authored-By: ajitbohra <ajit@lubus.in>

* Update & fix dead links

* Update README.md

* Update writing-your-first-block-type.md

* Update scripts.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants