Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the Tracks Sentry integration #12001

Merged
merged 5 commits into from
Jul 4, 2019
Merged

Use the Tracks Sentry integration #12001

merged 5 commits into from
Jul 4, 2019

Commits on Jul 4, 2019

  1. Use the Tracks Sentry integration 

    Clean up an extra comment

Fix code organization
    @jkmassel
    jkmassel committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    543c602 View commit details
    Browse the repository at this point in the history

  2. Add an assertion that helps debug failing tests 

    Without this assertion, a test can crash two lines later on `componentsWithURL`. When the crash happens, the debugger can’t trace back to where it happened. Adding this assertion fixes that.
    @jkmassel
    jkmassel committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    af00f71 View commit details
    Browse the repository at this point in the history

  3. Fix a test failure caused by overwriting symbols 

    When Sentry is statically linked, it can overwrite symbols defined in NSObject+SafeExpectations. Until we can remove this Objective-C extension, we’ll need to special-case this.
    @jkmassel
    jkmassel committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    6bd1b3a View commit details
    Browse the repository at this point in the history

  4. Fix the podfile

    @jkmassel
    jkmassel committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    415e4b4 View commit details
    Browse the repository at this point in the history

  5. Statically link tracks but not Sentry

    @jkmassel
    jkmassel committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    5c00167 View commit details
    Browse the repository at this point in the history