-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the Tracks Sentry integration #12001
Conversation
0a165ba
to
d2d6f47
Compare
There seems to be some failing tests here. I re-ran but it still seems to be red. |
d2d6f47
to
c62d44d
Compare
Well this was a little more complicated than I first expected. We use https://github.com/wordpress-mobile/NSObject-SafeExpectations which adds the I've filed an issue with Sentry (getsentry/sentry-cocoa#314), because I don't think they're deliberately exporting these symbols for use outside the library. In the mean time, I've disabled static compilation for Sentry and Tracks for the moment, but if we don't think that's an acceptable trade-off, we could see where Sentry lands with this and proceed at that time? We have an implementation that works, it's just inconsistent with the others. That bit of tech debt might be worth it for the optimizations provided by static compilation. WDYT? |
Ah, that is unexpected. This is a perfect example of why categories in libraries should always be prefixed 😄
I don't love this but I accept this may be the best trade off right now. Why does it need to be disabled for Tracks as well as Sentry? Perhaps I'm missing something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described. 🚢 it!
Clean up an extra comment Fix code organization
Without this assertion, a test can crash two lines later on `componentsWithURL`. When the crash happens, the debugger can’t trace back to where it happened. Adding this assertion fixes that.
When Sentry is statically linked, it can overwrite symbols defined in NSObject+SafeExpectations. Until we can remove this Objective-C extension, we’ll need to special-case this.
9900835
to
5c00167
Compare
Integrate Sentry using Tracks
To Test:
Run the app in a way that causes the code above to run, and verify that it shows up in Sentry.