Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Layout Updates to Active Filters Block #6905

Merged
merged 8 commits into from
Aug 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions assets/js/base/components/chip/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
align-items: center;
border: 0;
display: inline-flex;
padding: em($gap-smallest * 0.5) 0.5em em($gap-smallest);
padding: em($gap-smallest) 0.5em;
margin: 0 0.365em 0.365em 0;
border-radius: 0;
line-height: 1;
Expand All @@ -14,8 +14,9 @@
&:hover,
&:focus,
&:active {
background: $gray-200;
color: $gray-900;
background: transparent;
color: inherit;
border: 1px solid;
}

&.wc-block-components-chip--radius-small {
Expand All @@ -30,24 +31,27 @@
padding-right: 0.75em;
}
.wc-block-components-chip__text {
@include font-size(smaller);
flex-grow: 1;
}
&.is-removable {
padding-right: 0.5em;
}
&.is-removable .wc-block-components-chip__text {
padding-right: 0.25em;
}
.wc-block-components-chip__remove {
@include font-size(smaller);
background: transparent;
background: $gray-200;
border: 0;
border-radius: 25px;
appearance: none;
padding: 0;
height: 16px;
width: 16px;
margin: 0;
}

.wc-block-components-chip__remove-icon {
vertical-align: middle;
fill: $gray-900;
}
}

Expand All @@ -67,11 +71,15 @@ button.wc-block-components-chip:hover > .wc-block-components-chip__remove,
button.wc-block-components-chip:focus > .wc-block-components-chip__remove,
.wc-block-components-chip__remove:hover,
.wc-block-components-chip__remove:focus {
fill: $alert-red;
background: $gray-600;

.wc-block-components-chip__remove-icon {
fill: #fff;
}
}

button.wc-block-components-chip:disabled > .wc-block-components-chip__remove,
.wc-block-components-chip__remove:disabled {
fill: $gray-600;
fill: #fff;
cursor: not-allowed;
}
4 changes: 3 additions & 1 deletion assets/js/blocks/active-filters/edit.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import {
*/
import Block from './block';
import type { Attributes } from './types';
import './editor.scss';

const Edit = ( {
attributes,
Expand All @@ -37,7 +38,7 @@ const Edit = ( {
<InspectorControls key="inspector">
<PanelBody
title={ __(
'Block Settings',
'Display Settings',
'woo-gutenberg-products-block'
) }
>
Expand All @@ -52,6 +53,7 @@ const Edit = ( {
displayStyle: value,
} )
}
className="wc-block-active-filter__style-toggle"
>
<ToggleGroupControlOption
value="list"
Expand Down
9 changes: 9 additions & 0 deletions assets/js/blocks/active-filters/editor.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
.wc-block-active-filters {
.wc-block-active-filters__list-item-name {
margin-top: 9px;
}
}

.wc-block-active-filter__style-toggle {
width: 100%;
}
32 changes: 21 additions & 11 deletions assets/js/blocks/active-filters/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
overflow: hidden;

.wc-block-active-filters__clear-all {
@include font-size(regular);
float: right;
@include font-size(smaller);
border: none;
margin-top: 15px;
padding: 0;
text-decoration: underline;
cursor: pointer;
Expand All @@ -37,10 +37,9 @@
clear: both;

li {
margin: 0;
margin: 9px 0 0;
padding: 0;
list-style: none outside;
clear: both;

ul {
margin: 0;
Expand All @@ -54,10 +53,14 @@
}
}
}
> li:first-child {
margin: 0;
}
}

.wc-block-active-filters__list-item-type {
@include font-size(smaller);
font-weight: bold;
text-transform: uppercase;
letter-spacing: 0.1em;
margin: $gap 0 0;
Expand All @@ -70,10 +73,11 @@
}

.wc-block-active-filters__list-item-name {
font-weight: bold;
display: block;
@include font-size(smaller);
display: flex;
align-items: center;
position: relative;
padding: 0 16px 0 0;
padding: 0;
}

.wc-block-active-filters__list-item-remove {
Expand All @@ -83,11 +87,17 @@
height: 16px;
width: 16px;
padding: 0;
position: absolute;
right: 0;
top: 50%;
margin: -8px 0 0 0;
margin: 0 16px 0 0;
color: currentColor;

&:hover {
color: $gray-600;
}

&:disabled {
color: $gray-200;
cursor: not-allowed;
}
}

.wc-block-active-filters__list--chips {
Expand Down
3 changes: 1 addition & 2 deletions assets/js/blocks/active-filters/utils.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ export const renderRemovableListItem = ( {
/>
) : (
<span className="wc-block-active-filters__list-item-name">
{ prefixedName }
<button
className="wc-block-active-filters__list-item-remove"
onClick={ removeCallback }
Expand Down Expand Up @@ -141,9 +140,9 @@ export const renderRemovableListItem = ( {
fill="white"
/>
</svg>

<Label screenReaderLabel={ removeText } />
</button>
{ prefixedName }
</span>
) }
</li>
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/specs/shopper/active-filters.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ const getActiveFilterTypeText = () =>
const getActiveFilterNameText = () =>
page.$eval(
selectors.frontend.activeFilterName,
( el ) => ( el as HTMLElement ).childNodes[ 0 ].textContent
( el ) => ( el as HTMLElement ).childNodes[ 1 ].textContent
);

describe( 'Shopper → Active Filters Block', () => {
Expand Down