This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Layout Updates to Active Filters Block #6905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: |
|
Size Change: +230 B (0%) Total Size: 870 kB
ℹ️ View Unchanged
|
danielwrobert
force-pushed
the
update/active-filters-ui
branch
from
2f4e3e0
to
c7a3941
Compare
danielwrobert
added
block-type: filter blocks
danielwrobert
changed the title
danielwrobert
force-pushed
the
update/active-filters-ui
branch
from
c7a3941
to
69733ac
Compare
rubikuserbot
requested review from
a team and
sunyatasattva
and removed request for
a team
|
Note: There is still an open question here but we may be able to merge this as-is and, if needed, follow up on the color adjustments in a subsequent PR. |
Additionally, add editor styles to have the editor match the rendered frontend.
- Add hover state to remove button on chip layout. - Update disabled styles to remove button in both layouts (mainly relevant to the editor view).
Set hover states to shades of grey. Also set chip color and text to match selected text color of the block.
danielwrobert
force-pushed
the
update/active-filters-ui
branch
from
69733ac
to
f438478
Compare
|
Investigating the failed tests. I believe it may be due to me changing the order of the filter and the Remove buttons in List view. The UPDATE: Adjustment in 1c595da seems to take care of it! |
Since we're moving the remove button in the list view from the last child node to the first child node, we need to adjust the expected order of the active filter item text.
albarin
approved these changes
Aug 26, 2022
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
* Reverse ordter of filter item name and close btn. * Update layout & typography styles for block items * Update chip ui view styles. Additionally, add editor styles to have the editor match the rendered frontend. * Update additional remove button styles. - Add hover state to remove button on chip layout. - Update disabled styles to remove button in both layouts (mainly relevant to the editor view). * Adjust remove button colors. Set hover states to shades of grey. Also set chip color and text to match selected text color of the block. * Update e2e test to account for new element order. Since we're moving the remove button in the list view from the last child node to the first child node, we need to adjust the expected order of the active filter item text. * Design and copy updates on the block settings Co-authored-by: Alba Rincón <albarin@users.noreply.github.com> Co-authored-by: Alba Rincón <alba.rincon@automattic.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update layouts for the Chips and List views on the Active Filters block, according to the new design proposal (pdnLyh-1SH-p2).
Note that the alternate color options and layouts will be done in a follow-up task.
Fixes #6844
Accessibility
prefers-reduced-motionScreenshots
Testing
WooCommerce Visibility
Changelog