Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix coverage combine for different OS's #778

Merged
merged 16 commits into from
Feb 23, 2024

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Feb 21, 2024

Different OS's are producing the same files currently. Noticed in #762. I think this might be why #772 is failing, too.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii mentioned this pull request Feb 21, 2024
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@cjolowicz
Copy link
Collaborator

Would something like this help with merging the Windows paths?

[tool.coverage.paths]
source = ["nox", "*/site-packages"]

[tool.coverage.run]
source = ["nox"]

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
Copy link
Collaborator Author

I can try it. Have no idea why the D:\a\nox\nox\__init__.py is not being reported as a relative path.

@edgarrmondragon
Copy link
Contributor

fwiw running coverage with --debug=pathmap might help

@henryiii
Copy link
Collaborator Author

I'll try that, as the first one didn't work. I also might upload the .coverage files.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
Copy link
Collaborator Author

When it works, it shows Matched path 'D:\\a\\nox\\nox\\nox\\workflow.py' to rule '*/nox' -> 'nox/', producing 'nox/workflow.py'. Not sure what a failing run looks like.

@henryiii
Copy link
Collaborator Author

FYI, this is what the coverage looks like:

sqlite> SELECT * FROM file;
1|D:\a\nox\nox\nox\__init__.py
2|D:\a\nox\nox\nox\_options.py
3|D:\a\nox\nox\nox\_option_set.py
4|D:\a\nox\nox\nox\tasks.py
5|D:\a\nox\nox\nox\registry.py
6|D:\a\nox\nox\nox\_decorators.py
7|D:\a\nox\nox\nox\_typing.py
8|D:\a\nox\nox\nox\_version.py
9|D:\a\nox\nox\nox\logger.py
10|D:\a\nox\nox\nox\manifest.py
11|D:\a\nox\nox\nox\sessions.py
12|D:\a\nox\nox\nox\command.py
13|D:\a\nox\nox\nox\popen.py
14|D:\a\nox\nox\nox\virtualenv.py
15|D:\a\nox\nox\nox\_parametrize.py
16|D:\a\nox\nox\nox\tox_to_nox.py
17|D:\a\nox\nox\nox\workflow.py
18|D:\a\nox\nox\nox\__main__.py
19|nox\__init__.py
20|nox\_options.py
21|nox\_option_set.py
22|nox\tasks.py
23|nox\registry.py
24|nox\_decorators.py
25|nox\_version.py
26|nox\logger.py
27|nox\manifest.py
28|nox\sessions.py
29|nox\command.py
30|nox\popen.py
31|nox\virtualenv.py
32|nox\_parametrize.py
33|nox\__main__.py
34|nox\workflow.py
35|nox\tox_to_nox.py
36|nox\_typing.py

This is true for both passing and failing tests AFAICT.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/ci/fixcov2 branch 3 times, most recently from fe2b906 to a9eab64 Compare February 23, 2024 02:13
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
Copy link
Collaborator Author

Going to try using an omit pattern, that's a little cleaner if it works. Will revert if not.

henryiii and others added 2 commits February 22, 2024 22:25
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@cjolowicz cjolowicz merged commit 911b800 into wntrblm:main Feb 23, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants