Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update to artifacts v2 #772

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Feb 20, 2024

This updates to artifacts v2 (upload/download v4). Artifacts are immutable in the new system.

Following suggestions from pipx run sp-repo-review[cli] . (available in WASM here: https://learn.scientific-python.org/development/guides/repo-review/?repo=wntrblm%2Fnox&branch=main).

@henryiii
Copy link
Collaborator Author

I think rebasing on #778 will fix this. I think theres a data corruption bug if you combine files with the same name.

Copy link
Collaborator

@theacodes theacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending CI passing.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii merged commit ffdbb6c into wntrblm:main Feb 23, 2024
40 checks passed
@henryiii henryiii deleted the henryiii/ci/artifactsv2 branch February 23, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants