fix(cloudflare): base strip logic #6550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 459c7d7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
RichiCoder1
force-pushed
the
fix/error_cf_fix
branch
from
379f84e
to
5be1cd0
Compare
bluwy
reviewed
Mar 15, 2023
Fixes the strip logic for _config.base. Apparently the negative indexing is a feature of the deprecated substr, not substring.
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
RichiCoder1
force-pushed
the
fix/error_cf_fix
branch
from
cf04cef
to
459c7d7
Compare
bluwy
approved these changes
Mar 16, 2023
|
Thanks for following up! |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes the strip logic for _config.base. Apparently the negative indexing is a feature of the deprecated substr, not substring.
Apologies for not catching this the first time around.
Testing
Manually tested via
patch-packagelocally. Verified behavior is correct now.Docs
N/A