Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudflare Adapter in Directory Mode doesn't respect base #6471

Closed
1 task
RichiCoder1 opened this issue Mar 9, 2023 · 2 comments
Closed
1 task

Cloudflare Adapter in Directory Mode doesn't respect base #6471

RichiCoder1 opened this issue Mar 9, 2023 · 2 comments

Comments

@RichiCoder1
Copy link
Contributor

RichiCoder1 commented Mar 9, 2023

What version of astro are you using?

v2.1.2

Are you using an SSR adapter? If so, which one?

Cloudflare

What package manager are you using?

npm

What operating system are you using?

Windows

Describe the Bug

When generating the function and SSR _routes.json for Cloudflare, the adapter will not respect the base option resulting in basic routes 404-ing.

The applies to both SSR and prerender'd routes (due to an issue both with the generated function, and the _routes.json not being mapped to base.

Edit: this seems to also affect prerender'd routes in advanced mode, as the _routes.json is still wrong.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-4ru86g?file=astro.config.mjs

Participation

  • I am willing to submit a pull request for this issue.
@bluwy
Copy link
Member

bluwy commented Mar 28, 2023

@RichiCoder1 is this fixed with #6473 merged?

@RichiCoder1
Copy link
Contributor Author

@bluwy yup, was fully resolved with #6550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants