Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pin node/npm version for build workflow #1496

Merged
merged 7 commits into from
Feb 9, 2023
Merged

chore: pin node/npm version for build workflow #1496

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
95330dc
DEBUG trying out some stuff
MarkMcCulloh Feb 9, 2023
97e8412
wow
MarkMcCulloh Feb 9, 2023
b18f796
test
MarkMcCulloh Feb 9, 2023
95131fc
use pinned node/npm version
MarkMcCulloh Feb 9, 2023
a0b933c
force sdk change
MarkMcCulloh Feb 9, 2023
1463601
ok I think that was the issue
MarkMcCulloh Feb 9, 2023
116981f
pr feedback
MarkMcCulloh Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 4 additions & 19 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ concurrency:
cancel-in-progress: true

env:
NODEJS_VERSION: "18.x"
# Testing runs out of memory without this
NODE_OPTIONS: "--max-old-space-size=4096"
PROJEN_BUMP_VERSION: "0.0.0-dev.${{ github.run_id }}.${{ github.run_attempt }}"
Expand Down Expand Up @@ -100,10 +99,8 @@ jobs:
- name: Checkout
uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: ${{ env.NODEJS_VERSION }}
- name: Setup Node/NPM
MarkMcCulloh marked this conversation as resolved.
Show resolved Hide resolved
Chriscbr marked this conversation as resolved.
Show resolved Hide resolved
uses: volta-cli/action@v4.0.0

- name: Install Rust
uses: actions-rs/toolchain@v1
Expand All @@ -121,21 +118,14 @@ jobs:
- name: Lint Nx
run: npx nx workspace-lint

- name: Build and Unit Test
- name: Build, Test, and Package
uses: MansaGroup/nrwl-nx-action@v2
with:
targets: "build"
targets: "build,test,package"
all: true
# Exclude E2E testing
args: "--exclude=hangar --configuration=release --output-style=stream --verbose"

- name: Create NPM packages
uses: MansaGroup/nrwl-nx-action@v2
with:
targets: "package"
projects: "winglang,sdk"
args: "--configuration=release --output-style=stream --verbose"

- name: Upload Wing CLI
uses: actions/upload-artifact@v2
with:
Expand Down Expand Up @@ -230,11 +220,6 @@ jobs:
- name: Download Build Artifacts
uses: actions/download-artifact@v2

- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: ${{ env.NODEJS_VERSION }}

- name: Tag commit
uses: tvdias/github-tagger@v0.0.1
if: ${{ needs.prepare.outputs.last-version != needs.prepare.outputs.version }}
Expand Down
2 changes: 1 addition & 1 deletion apps/jsii-docgen/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"executor": "nx:run-script",
"options": {
"cwd": "apps/jsii-docgen",
"script": "build"
"script": "compile"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion apps/wing-api-checker/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"executor": "nx:run-script",
"options": {
"cwd": "apps/wing-api-checker",
"script": "build"
"script": "compile"
}
}
}
Expand Down