Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin node/npm version for build workflow #1496

Merged
merged 7 commits into from
Feb 9, 2023
Merged

chore: pin node/npm version for build workflow #1496

merged 7 commits into from
Feb 9, 2023

Conversation

MarkMcCulloh
Copy link
Contributor

@MarkMcCulloh MarkMcCulloh commented Feb 9, 2023

Ok so during npm install symlinks were not being created where required. I believe this is some sort of regression with a new minor/patch version of node or npm. Using volta we already pin the node version locally, so it makes sense to do it in the workflow as well.

Removed any explicit node versioning where it is unnecessary.

Also combined all of the build into 1 command, because it shows the power of nx.

Fixes #1479 🤞

By submitting this pull request, I confirm that my contribution is made under the terms of the Monada Contribution License.

@MarkMcCulloh MarkMcCulloh requested a review from a team as a code owner February 9, 2023 15:47
Copy link
Contributor

@Chriscbr Chriscbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

during npm install symlinks were not being created where required



Would enabling this flag make any difference maybe? https://docs.npmjs.com/cli/v8/commands/npm-install#install-links

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@MarkMcCulloh
Copy link
Contributor Author

MarkMcCulloh commented Feb 9, 2023

Would enabling this flag make any difference maybe

Funnily enough, I think that's part of the "regression". A recent version of node 18 made npm 9 the default.

I had already added that flag to the npmrc, I mistakenly thought this fixed the previous issue with supporting npm9 (but npmrc doesn't apply to subdirs, whoops).
Even though npm reverted the change, I will go ahead and set the flag in the install scripts as well now.

@mergify
Copy link
Contributor

mergify bot commented Feb 9, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ce27718 into winglang:main Feb 9, 2023
@MarkMcCulloh MarkMcCulloh deleted the mark/fix-build branch February 9, 2023 22:15
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.5.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent build issue in wing playground and wing cli
3 participants