Add option to proxy requests #32
Conversation
| .or(env::var("http_proxy").ok()) | ||
| .or(env::var("HTTPS_PROXY").ok()); |
There was a problem hiding this comment.
This works for now but I think the intention with these env vars is that they can both be set and point to different proxy servers.
There was a problem hiding this comment.
I don't understand how this works in conjunction, should it decide to use a certain one depending on the request itself being http/https?
There was a problem hiding this comment.
I think it's a remnant of the early internet where you could have different proxies for different protocols. Here's Netscape on Mac OS 8.1
So yes, it would direct the request to depending on the protocol of the request. The example on https://docs.rs/reqwest/latest/reqwest/struct.Proxy.html demonstrates this: It uses Proxy::http with a https proxy url to "intercept all HTTP requests, and make use of the proxy at https://secure.example".
There was a problem hiding this comment.
Oh I see! Thanks for the interesting context, let me know if you think it's useful/needed and I could open another PR. I personally don't need it for my use.
There was a problem hiding this comment.
I think I’ll tweak it to match those semantics before publishing a release but no expectation for you to do it. I can do it.
|
Updated the PR with your suggestions, thanks! |
Resolves #30